From ed6085a27a82a66686faab58030f45b19bf6d346 Mon Sep 17 00:00:00 2001 From: Vince Picone Date: Wed, 18 Dec 2019 15:44:18 -0600 Subject: [PATCH 1/3] fix(Dropdown): rely on list-box height closes #4916 --- packages/components/src/components/dropdown/_dropdown.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/components/src/components/dropdown/_dropdown.scss b/packages/components/src/components/dropdown/_dropdown.scss index 2f882c2babeb..56146dfdbe15 100644 --- a/packages/components/src/components/dropdown/_dropdown.scss +++ b/packages/components/src/components/dropdown/_dropdown.scss @@ -51,7 +51,6 @@ border: none; border-bottom: 1px solid $ui-04; width: 100%; - height: rem(40px); cursor: pointer; color: $text-01; outline: 2px solid transparent; From 5f5ee879bdb2e25f7787c7b20fe0272f6cbbe74d Mon Sep 17 00:00:00 2001 From: "D.A. Kahn" Date: Wed, 22 Jan 2020 13:40:32 -0600 Subject: [PATCH 2/3] fix(tags): specify default cursor for non-filter tag --- packages/components/src/components/tag/_tag.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/src/components/tag/_tag.scss b/packages/components/src/components/tag/_tag.scss index f777029d53c6..7d806d854c66 100644 --- a/packages/components/src/components/tag/_tag.scss +++ b/packages/components/src/components/tag/_tag.scss @@ -26,6 +26,7 @@ max-width: 100%; // restricts size of contained elements margin: $carbon--spacing-02; border-radius: rem(15px); + cursor: default; &:not(:first-child) { margin-left: 0; From 801a486dc9e142161b5485de33d8e4498ea3ba2d Mon Sep 17 00:00:00 2001 From: "D.A. Kahn" Date: Wed, 22 Jan 2020 13:57:20 -0600 Subject: [PATCH 3/3] fix(tag): reverts default tag to span rather than button --- packages/react/src/components/Tag/Tag.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/Tag/Tag.js b/packages/react/src/components/Tag/Tag.js index 9b57e714bfb2..2b484c81b6b8 100644 --- a/packages/react/src/components/Tag/Tag.js +++ b/packages/react/src/components/Tag/Tag.js @@ -56,9 +56,9 @@ const Tag = ({ ) : ( - + ); };