Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript types to FullPageError #5668

Closed
6 tasks
Tracked by #4232
matthewgallo opened this issue Jul 15, 2024 · 0 comments · Fixed by #5746
Closed
6 tasks
Tracked by #4232

Add Typescript types to FullPageError #5668

matthewgallo opened this issue Jul 15, 2024 · 0 comments · Fixed by #5746
Assignees
Labels
adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. area: typescript role: dev type: enhancement 💡 New feature or request type: infrastructure 🤖 Issues related to devops, builds, packaging
Milestone

Comments

@matthewgallo
Copy link
Member

matthewgallo commented Jul 15, 2024

As we add Typescript support, want to call out a few helpful tips from the Carbon TypeScript guide that is largely relevant to our library as well.

Changing the extension via git

When changing the file extension — do not simply rename the file. Instead, change the extension via git.

For example,

git mv packages/ibm-products/src/components/ComponentName/ComponentName.js packages/ibm-products/src/components/ComponentName/ComponentName.tsx

Do not add types to internal components or functions

Testing changes

A few different options for testing changes —

  • At the bottom of a file, write a dummy component that uses the component that you’re converting to ensure that you can still pass all appropriate props.
  • Take a storybook example for a component, copy and paste it into the bottom of the .tsx file and validate whether or not it accepts the props as you’ve defined them.

Tasks

Resources

Carbon’s guide on adding component types

@matthewgallo matthewgallo added type: enhancement 💡 New feature or request type: infrastructure 🤖 Issues related to devops, builds, packaging area: typescript role: dev adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. and removed status: needs triage 🕵️‍♀️ labels Jul 16, 2024
@matthewgallo matthewgallo added this to the 2024 Q3 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. area: typescript role: dev type: enhancement 💡 New feature or request type: infrastructure 🤖 Issues related to devops, builds, packaging
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants