You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Creating an issue with the intent to create a CIP unless there is some obvious reason not to.
See the image below; the window.cardano[name] and window.cardano.[name].name can differ in case (and perhaps in other ways as well). This makes it unnecessarily hard to dynamically iterate available wallets, with the intent to window.cardano[key].enable() it.
I suggest to normalize the names to always be lowercase, and fully match the key they are registered under. If needed, we could instead add an additional property, key which must match the corresponding key in window.cardano.
The point against this is that this can be derrived by the key itself, but this just adds more complexity where it does not need to be.
Creating an issue with the intent to create a CIP unless there is some obvious reason not to.
See the image below; the
window.cardano[name]
andwindow.cardano.[name].name
can differ in case (and perhaps in other ways as well). This makes it unnecessarily hard to dynamically iterate available wallets, with the intent towindow.cardano[key].enable()
it.I suggest to normalize the names to always be lowercase, and fully match the key they are registered under. If needed, we could instead add an additional property,
key
which must match the corresponding key inwindow.cardano
.The point against this is that this can be derrived by the key itself, but this just adds more complexity where it does not need to be.
CC @alessandrokonrad
The text was updated successfully, but these errors were encountered: