Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update cypress ui testing for pool (MET-1481) #1496

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Feature: update cypress ui testing for pool (MET-1481) #1496

merged 6 commits into from
Aug 4, 2023

Conversation

Sotatek-DavidNguyen4
Copy link
Collaborator

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 removed the hold Hold label Aug 1, 2023
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 added the cf-review CF Review needed label Aug 1, 2023
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 marked this pull request as ready for review August 1, 2023 04:37
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 added hold Hold and removed cf-review CF Review needed labels Aug 1, 2023
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 marked this pull request as draft August 1, 2023 06:49
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 added cf-review CF Review needed and removed hold Hold labels Aug 2, 2023
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 marked this pull request as ready for review August 2, 2023 06:43
rcmorano and others added 2 commits August 3, 2023 21:12
@rcmorano @jimcase
chore(gha): reverting to github-managed runners
4358c6d
@jimcase
Squashed commit of the following:
dc42b7a 
commit 9bab226
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:56:42 2023 +0700

    fix: env default for testing failed

commit f2f6e90
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 10:36:49 2023 +0700

    fix(tests): TokenTransaction.test.tsx

commit 3242dca
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:25:09 2023 +0700

    fix(tests): ReportDetailStakeyTabs.test.tsx

commit a439f5e
Merge: 0b53c5d 536b44e
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:11:51 2023 +0700

    Merge branch 'chore/fix-unit-jest-test' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit 536b44e
Author: Truong Manh Nguyen (truong.nguyen4) <[email protected]>
Date:   Thu Aug 3 10:10:44 2023 +0700

    chore: fix unit jest test

commit 0b53c5d
Merge: 417949f b744b7f
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:08:25 2023 +0700

    Merge branch 'bugfix/unit-test-failed' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit b744b7f
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 10:05:28 2023 +0700

    fix(tests): ContractDetail.test.tsx

commit 417949f
Merge: 5b71a08 ef4b7e9
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 09:59:52 2023 +0700

    Merge branch 'bugfix/unit-test-failed' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit 52c585e
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 09:59:12 2023 +0700

    fix(tests): Home.test.tsx

commit 5b71a08
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 09:58:19 2023 +0700

    fix: update unit test

commit ef4b7e9
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:41:55 2023 +0700

    fix(tests): DetailViewContractHash.test.tsx

commit 782a4a0
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:38:29 2023 +0700

    fix(tests): Delegations.test.tsx

commit 8eda41f
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:37:00 2023 +0700

    fix(tests): ToastContainer.test.tsx

commit b884efd
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:33:26 2023 +0700

    fix(tests): TokenAutocomplete.test.tsx

commit c621f49
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:30:32 2023 +0700

    fix(tests): Statistic.test.tsx

commit 4149d91
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:14:01 2023 +0700

    fix(tests): TransactionChart.test.tsx

commit 914699e
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:06:07 2023 +0700

    fix(tests): TopDelegators.test.tsx

commit 4fc1358
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:04:10 2023 +0700

    fix(tests): DetailViewToken.test.tsx

commit 6e6c9b7
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:55:13 2023 +0700

    fix(tests): ContractDetailContent.test.tsx

commit bc14d3d
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:53:23 2023 +0700

    fix(tests): DelegationOverview.test.tsx

commit 8ea9a61
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:50:58 2023 +0700

    fix(tests): Layout.test.tsx

commit 3d5a1be
Merge: cbffaa3 e1f5eea
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:46:38 2023 +0700

    Merge pull request #1493 from cardano-foundation/bugfix/MET-615-fix-next-page-of-seach-tokens

    fix: MET-615 reset paging when search token

commit cbffaa3
Merge: f48960d a3fff4c
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:43:50 2023 +0700

    Merge pull request #1465 from cardano-foundation/bugfix/MET-615-Stake-address-registrarion-display-text-tot-delegated-to-any-pool

    fix: Stake-address-registrarion-display-text-tot-delegated-to-any-poo…

commit f48960d
Merge: 2c45e7f 260937e
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:43:40 2023 +0700

    Merge pull request #1457 from cardano-foundation/bugfix/MET-1394-report-detail-text-deregistration-wrong

    fix: report-detail-text-deregistration-wrong( MET-1394 )

commit e1f5eea
Author: trung.hoang <[email protected]>
Date:   Tue Aug 1 10:24:14 2023 +0700

    fix: MET-615 fix net page of seach token

commit a3fff4c
Author: huy.nguyen <[email protected]>
Date:   Mon Jul 31 14:51:51 2023 +0700

    fix: Stake-address-registrarion-display-text-tot-delegated-to-any-pool(MET-615)

commit 260937e
Author: huy.nguyen <[email protected]>
Date:   Mon Jul 31 10:05:16 2023 +0700

    fix: report-detail-text-deregistration-wrong( MET-1394 )
@jimcase jimcase merged commit 1c2bc0a into develop Aug 4, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Merged
@sato-thuyetnguyen sato-thuyetnguyen deleted the feature/MET-1481-cypress-ui-testing-for-pool branch August 10, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimcase jimcase jimcase approved these changes

@fabianbormann fabianbormann Awaiting requested review from fabianbormann

Assignees

@fabianbormann fabianbormann

@jimcase jimcase

Labels
cf-review CF Review needed test-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sotatek-DavidNguyen4 @jimcase @fabianbormann @satran004 @rcmorano