Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the unnecessary button's border (MET-1489) #1589

Conversation

Sotatek-TungPham
Copy link
Collaborator

@Sotatek-TungPham Sotatek-TungPham commented Aug 4, 2023

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before After

|Screenshot 2023-08-04 at 15 02 28|
Screenshot 2023-08-04 at 15 03 29|

@Sotatek-TungPham Sotatek-TungPham force-pushed the bugfix/MET-1489-finding-1-remove-border-of-selecting-chart-time-button branch from 307f23a to 037d6bc Compare August 4, 2023 10:29
@Sotatek-TungPham Sotatek-TungPham removed the hold Hold label Aug 4, 2023
@Sotatek-TungPham Sotatek-TungPham marked this pull request as ready for review August 4, 2023 10:50
…rontend into bugfix/MET-1489-finding-1-remove-border-of-selecting-chart-time-button
@jimcase jimcase merged commit c67e1d3 into develop Aug 5, 2023
3 checks passed
@Sotatek-NgocTran3 Sotatek-NgocTran3 deleted the bugfix/MET-1489-finding-1-remove-border-of-selecting-chart-time-button branch August 9, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cf-review CF Review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants