Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MET-615 handle no asset name in minting tab of transaction detail #1615

Conversation

Sotatek-TruongNguyen4
Copy link
Collaborator

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 commented Aug 7, 2023

Description

Handle the absence of an asset name in the minting tab of the transaction detail.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: MET-615

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before
After

Safari

Before
After

Responsive

Before
After

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 added hold Hold cf-review CF Review needed and removed hold Hold labels Aug 7, 2023
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as ready for review August 8, 2023 02:30
@jimcase jimcase merged commit be59ba5 into develop Aug 8, 2023
3 checks passed
@sato-thuyetnguyen sato-thuyetnguyen deleted the bugfix/MET-615-handle-no-assetname-minting-tab-transaction-detail branch August 10, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cf-review CF Review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants