Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MET-1343 Finding 1 3 Remove Icon SPO and able to click the whole box reward account #657

Conversation

Sotatek-TruongNguyen4
Copy link
Collaborator

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 commented Jun 22, 2023

… box reward account

Description

Fix Finding 1 3 MET 1343 : Remove Icon SPO and able to click the whole box reward account

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: MET-1343

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

Before

image

After

image

Safari

Before
After

Responsive

Before
After

@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as ready for review June 23, 2023 05:13
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as draft June 24, 2023 03:06
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as ready for review June 26, 2023 03:10
@Sotatek-TrungHoang Sotatek-TrungHoang added the cf-review CF Review needed label Jun 26, 2023
@cfuisat cfuisat assigned sato-thuyetnguyen and unassigned cfuisat Jun 26, 2023
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 marked this pull request as draft June 27, 2023 02:52
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 changed the title Fix: MET-1243 Finding 1 3 Remove Icon SPO and able to click the whole box reward account Fix: MET-1343 Finding 1 3 Remove Icon SPO and able to click the whole box reward account Jun 27, 2023
@Sotatek-TruongNguyen4 Sotatek-TruongNguyen4 deleted the bugfix/MET-1243-Finding1-3-remove-icon-SPO-and-able-click-the-whole-box-reward-acc branch June 27, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cf-review CF Review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants