Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting in the TUI when transaction posting fails on chain #531

Closed
1 task done
Tracked by #518
pgrange opened this issue Oct 4, 2022 · 2 comments · Fixed by #577 or #582
Closed
1 task done
Tracked by #518

Better error reporting in the TUI when transaction posting fails on chain #531

pgrange opened this issue Oct 4, 2022 · 2 comments · Fixed by #577 or #582
Assignees
Labels
task Subtask of a bigger feature.
Milestone

Comments

@pgrange
Copy link
Contributor

pgrange commented Oct 4, 2022

Problem: When a tx submission fails it's not clear why because the error messages are obscure/cryptic/not visible
We cannot remember exactly what the problem was initially so we need to make sure we clarify the problem

Goal: We want the node to provide better error reporting when a L1 transaction posting fails (not when it's not observed) immediately, possibly giving a human-understandable message :)

  • Reproduce manually issue on a working head, possible steps:
    • ensure the user does not have enough fund to post init tx (or will lead to a lower than minimal UTxO)
    • start a head in TUI
    • post init
    • see it fail -> is it understandable/visible/actionable?
@ch1bo ch1bo added the task Subtask of a bigger feature. label Oct 4, 2022
@v0d1ch v0d1ch self-assigned this Oct 17, 2022
@pgrange
Copy link
Contributor Author

pgrange commented Oct 18, 2022

We should have given more details to this story.

We should try to open our head again to see if we stumble upon the issue again

See #366 for more context to this issue

@ch1bo ch1bo added this to the 0.8.0 milestone Oct 20, 2022
@pgrange pgrange reopened this Oct 25, 2022
@pgrange
Copy link
Contributor Author

pgrange commented Oct 25, 2022

These are the big 5 potential errors which output we can improve:

data ErrCoverFee
  = ErrNoAvailableUTxO
  | ErrNotEnoughFunds Text
  | ErrUnknownInput Text
  | ErrNoPaymentUTxOFound Text
  | ErrScriptExecutionFailed Text
  | ErrCostEstimation Text

We should focus on errors for which a user can do something about so that we help him fix the situation and let the other errors as they are for now:

  • ErrNotEnoughFunds
  • ErrNoPaymentUTxOFound
  • ErrNoAvailableUTxO

Out of scope for now ("more details in the logs"):

  • ErrUnknownInput
  • ErrCostEstimation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Subtask of a bigger feature.
Projects
None yet
4 participants