-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] commonjs mods can only export default
#6
Comments
Why can't CommonJS modules use only named exports? |
@ericf check the discussion from the link, there is a lot of info there about why we should probably do that. |
default
default
@caridy I read the whole post. But passed on the title of this issue and it's lack of description, I'm asking for some clarity, because I don't understand what you're proposing. |
ah, ok. This pkg contains an npm module resolver that detects npm dependencies and creates a synthetic es6 module that contains named exports for any member of the |
I thought this package only deals with resolving ES6 imports of other ES6 modules that are in other npm packages. Where does this package deal with looking at CommonJS modules? 😕 |
I don't follow this. |
Where does this package import CJS modules today? I thought it only produces CJS modules via the transpiler. |
this is the line that I want to remove: https://github.com/caridy/grunt-bundle-jsnext-lib/blob/master/lib/npm-resolver.js#L45 |
that obviously means we need to change all our pkgs. |
based on this discussion: babel/babel#95 (comment)
The text was updated successfully, but these errors were encountered: