Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created paths inside the bucket seem to be incorrect #198

Open
steve-todorov opened this issue Feb 1, 2021 · 0 comments
Open

Created paths inside the bucket seem to be incorrect #198

steve-todorov opened this issue Feb 1, 2021 · 0 comments
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence on hold

Comments

@steve-todorov
Copy link
Collaborator

steve-todorov commented Feb 1, 2021

Bug Description

Running integration tests (and probably when using the s3fs-nio lib) creates a root / object and additional / objects inside some empty "directories". This is an issue for two reasons:

  1. When you do fileSystemAmazon.getPath(bucket, "/") one would expect to be receiving the bucket root path - not an object named /. :)

  2. Creating / objects in empty paths introduces additional operational costs because update/delete operations are counted per objects and are taxed by 1000 API requests. The more API requests you make - the more you would need to pay.

Suspected code?

  • FilesIT#bucketIsDirectory
  • FilesIT#fileIsReadableBucket
  • S3ClientIT#putObjectWithStartSlash

Steps To Reproduce

Needs to be narrowed down, but if you run the S3 integration tests the result will be visible:

mvn clean install -Pit-s3

Screenshots

image

image

image

Relationships

This task is:

@steve-todorov steve-todorov added bug Something isn't working needs triage The issue needs to be triaged, before work can commence on hold labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence on hold
Projects
None yet
Development

No branches or pull requests

1 participant