Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels update #42

Open
hhsnopek opened this issue Dec 21, 2016 · 5 comments
Open

labels update #42

hhsnopek opened this issue Dec 21, 2016 · 5 comments
Labels

Comments

@hhsnopek
Copy link
Contributor

Sometimes I'd like to update the existing labels of a repository to their proper label set. There's a particular edge case; The repository could contain additional tags that were added post setup.

Proposal:

ash github:labels update org/repo [label set]
> There were additional labels found when updating the label set for org/repo. Would
  you like to remove these tags? (y/N/all): 

# Y
> Would you like to remove labelA - #color (y/N): y
> Would you like to remove labelB - #color (y/N): n
> Would you like to remove labelC - #color (y/N): y
...
> The following labels were deleted: labelA, labelC
> Labels were successfully updated.

# N
> Labels were successfully updated.

# All
> Please type in the name of the repository to confirm: org/repo
> Labels were successfully updated.
@hhsnopek hhsnopek changed the title labels fix/change/update/clean labels update Dec 21, 2016
@BrandonRomano
Copy link
Contributor

I think I say 👎 -- If a repo has labels that exist beyond the defaults, I am against having them be removed in an automated fashion (even though there are confirmations). The history of the labels themselves may be useful (perhaps there is a label like blocked that show you information that something was at one point blocked)... It is particularly hard to tell if a label is totally unused.

Really, the only use case github:labels should have is immediately following a repo's creation.

@hhsnopek
Copy link
Contributor Author

I'm an edge case type of guy 😉 - but you don't have to remove them, you could just select no and update the colors to the existing labels and add missing labels

@BrandonRomano
Copy link
Contributor

The amount of time to implement this would exceed all cases of you ever wanting to delete labels that have already been created through the Github UI, I bet 🤔

@hhsnopek
Copy link
Contributor Author

ehh I've had it once or twice where I selected carrot-android or carrot-ios and I had to either create a labels-config for deleting them all with -delete:all or recreate the repo

@BrandonRomano
Copy link
Contributor

do we have a labels config to delete all things?

Perhaps we can create a ash github:labels update org/repo clear that simply clears them all out.

You'll have to do 2 commands, but it will literally be a single line to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants