Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the registry used on windows tests #288

Open
joaopapereira opened this issue Oct 25, 2021 · 4 comments
Open

Change the registry used on windows tests #288

joaopapereira opened this issue Oct 25, 2021 · 4 comments
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request Hacktoberfest Issues that are ready for Hacktoberfest participants.

Comments

@joaopapereira
Copy link
Member

Describe the problem/challenge you have
When running the tests in windows instead of relying on ttl.sh ephemeral registry we should explore other options since we have seen, lately, tests flaking because the images were removed from the registry

Describe the solution you'd like
look for an equivalent image to registry:v2 or eventually create a binary that run a simple registry for us to do tests.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@joaopapereira joaopapereira added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Oct 25, 2021
@joaopapereira
Copy link
Member Author

We found a dockerfile that we can use to generate a registry that runs in windows in https://github.com/StefanScherer/dockerfiles-windows/blob/main/registry
This image can be stored in our docker hub account.

We should create a script in our hack folder that would allow us to regenerate this image in an easy way.

@joaopapereira joaopapereira added carvel accepted This issue should be considered for future work and that the triage process has been completed Hacktoberfest Issues that are ready for Hacktoberfest participants. and removed carvel triage This issue has not yet been reviewed for validity labels Oct 25, 2021
@cppforlife
Copy link
Contributor

@joaopapereira why dont we just go build the binary on the fly and run it directly instead of using docker for this?

@joaopapereira
Copy link
Member Author

That is another option 😄 we just need to launch it in background and should be good

@joaopapereira
Copy link
Member Author

This was accomplish with #332 nevertheless we are back to using ttl.sh for performance tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request Hacktoberfest Issues that are ready for Hacktoberfest participants.
Projects
Status: Unprioritized
Development

No branches or pull requests

2 participants