Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to reference a GitRepository resource #1335

Open
warroyo opened this issue Sep 25, 2023 · 5 comments
Open

Add the ability to reference a GitRepository resource #1335

warroyo opened this issue Sep 25, 2023 · 5 comments
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request

Comments

@warroyo
Copy link

warroyo commented Sep 25, 2023

Right now there is some overlap when using Flux and Kapp controller together. Flux already provides the source controller to be able to poll a git repo. Kapp also has this functionality. It would be really nice to be able to use the Flux controller's GitRepository resource as a source for the Kapp controller. Today I can use the app.spec.fetch.http to reference the tar that the GitRepository creates, but that is not sustainable. being able to reference the GitRepository natively within the app spec would make this really easy to use and essentially turn Kapp into a flux controller .

I would propose that we add app.spec.fetch.GitRepository (or something similar) to the spec so that this can be done natively.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@warroyo warroyo added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Sep 25, 2023
@vrabbi
Copy link

vrabbi commented Sep 26, 2023

I like the idea, but would recommend maybe a bit more generic then the gitrepository resource, we could make it require the gvk and then support any of the source controllers objects which all follow the same contract as the gitrepository one such as the s3 and oci sources as well. Maybe calling the field FluxSource and then we could support any of them.

@warroyo
Copy link
Author

warroyo commented Oct 26, 2023

I did an experiment to get this working using flux + secretGen controller and it worked. it's a bit more complicated then I would hope so having this work natively would be great. https://github.com/warroyo/kapp-flux-example

Copy link

github-actions bot commented Dec 6, 2023

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Dec 6, 2023
@praveenrewar praveenrewar removed the stale This issue has had no activity for a while and will be closed soon label Dec 6, 2023
@renuy renuy added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jan 9, 2024
@100mik
Copy link
Contributor

100mik commented Jan 9, 2024

This sounds like something that #1413 will resolve, allowing folks to build out pluggable bits

@voor
Copy link

voor commented Feb 14, 2024

This is something that might help resolve carvel-dev/vendir#361 as well, as Flux's GitRepository can properly talk to basic auth servers (which the git cli struggles with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

6 participants