Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated workflow to automate github and pub.dev release #47

Merged
merged 3 commits into from
Aug 20, 2021
Merged

feat: updated workflow to automate github and pub.dev release #47

merged 3 commits into from
Aug 20, 2021

Conversation

MrUnfunny
Copy link
Contributor

@MrUnfunny MrUnfunny commented Aug 19, 2021

Fix: #45

@hsluoyz @KNawm please review. We will need to add a secret named PUB_CREDENTIALS according to this instruction.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 19, 2021

@MrUnfunny is that the Gmail password? Added.

image

@MrUnfunny
Copy link
Contributor Author

MrUnfunny commented Aug 19, 2021

@hsluoyz no, when you manually publish the package, it creates a credentials.json file in .pub-cache. That file's data should be added here.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 19, 2021

@MrUnfunny Unfortunately I have migrated to a new computer and the .pub-cache folder is lost. How to do it?

@MrUnfunny
Copy link
Contributor Author

@hsluoyz I think you'll need to publish a newer version on pub.dev to generate it again.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

@MrUnfunny can you fix this first? When I run dart pub publish --dry-run, I saw:

image

@MrUnfunny
Copy link
Contributor Author

@hsluoyz should I send a new PR for this or change in this PR only?

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

@MrUnfunny new PR plz

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

@MrUnfunny v0.1.0 done: https://pub.dev/packages/casbin

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

Done with secret:

image

@hsluoyz hsluoyz merged commit e5692df into casbin:master Aug 20, 2021
github-actions bot pushed a commit that referenced this pull request Aug 20, 2021
# [0.1.0](v0.0.1...v0.1.0) (2021-08-20)

### Bug Fixes

* better error texts in defaultRoleManager ([59b525f](59b525f))
* fix return of enforce method ([0b154ac](0b154ac))
* fixed assertion issue ([480a05e](480a05e))
* fixed exceptions to be more specific ([2ef8b36](2ef8b36))
* fixed suggested changes ([8f9048b](8f9048b))

### Features

* added classes and methods to load model from CONF file ([411d7bf](411d7bf))
* added github actions for analysing code and running test on PR and pushes ([66cf631](66cf631))
* added license text in all dart files ([c4135fe](c4135fe))
* added license text to new files ([a9e6ee9](a9e6ee9))
* added missing methods to enforcer apis ([858f8d7](858f8d7))
* added missing methods to model module ([106b363](106b363))
* added more methods to enforcer ([664af28](664af28))
* added required methods to enforcer apis ([8867283](8867283))
* added support for abac and added tests ([6ea535d](6ea535d))
* added tests for enforcer and management api ([596d604](596d604))
* added tests for logger ([b5333c4](b5333c4))
* added tests for matcher functions ([6e27cd8](6e27cd8))
* added tests for matcher functions ([39b4285](39b4285))
* exported required files ([bdd612a](bdd612a))
* fixed small issue and added tests ([bdfaccc](bdfaccc))
* Implement config interface ([cb57ee0](cb57ee0))
* implemented enforce to create minimum working prototype ([2eb8d01](2eb8d01))
* implemented logger ([9af6435](9af6435))
* implemented matcher functions - part 1 ([ccb2e1b](ccb2e1b))
* implemented methods for enforcer, coreEnforcer and added tests ([6354ab5](6354ab5))
* implemented missing methods to file adapter ([e9c4568](e9c4568))
* implemented missing parts of persist module ([4682653](4682653))
* implemented proper functioning enforce method and added tests for rbac ([#28](#28)) ([17b498c](17b498c))
* implemented remaining matcher functions ([316947d](316947d))
* prepared for new release ([#48](#48)) ([eee526a](eee526a))
* updated lint rules to prefer relative imports ([438a9fb](438a9fb))
* updated workflow to automate github and pub.dev release ([#47](#47)) ([e5692df](e5692df))
@github-actions
Copy link

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@MrUnfunny
Copy link
Contributor Author

@hsluoyz the workflow seems to work fine. The publish step failed because we already had v0.1.0 on pub.dev. Apart from this, it seems fine.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

@MrUnfunny so I think we doesn't need to do anything for now, right? It will auto go well for next release?

@MrUnfunny
Copy link
Contributor Author

yes. But still, to be sure, I'll soon implement IPMatchFunc or getImplicitRoles. Then we can test the publish step as well.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 20, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release on pub.dev
2 participants