fix: replace fnmatch with wcmatch for glob match, keep same behavior with Go Casbin #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zxilly <[email protected]>
Signed-off-by: Zxilly <[email protected]>
|
@hsluoyz @techoner plz review |
|
@Zxilly plz fix:
I saw you already sent and merged a PR to remove Py 3.5. Maybe you need to open a new PR to "refresh" the checks. |
Signed-off-by: Zxilly <[email protected]>
hsluoyz
requested changes
May 12, 2021
hsluoyz
changed the title
hsluoyz
approved these changes
May 12, 2021
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2021
## [1.0.5](v1.0.4...v1.0.5) (2021-05-12) ### Bug Fixes * replace fnmatch with wcmatch for glob match, keep same behavior with Go Casbin ([#149](#149)) ([906f40c](906f40c))
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #148
Signed-off-by: Zxilly [email protected]
ref to discussion at https://bugs.python.org/issue28718, it'll be complicated to implement it.
So I have to introduce a new dependency
wcmatch.