Store metadata with installed Casks. #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2014
| @@ -3,6 +3,11 @@ def destination_path | |||
| caskroom_path.children.first | |||
| end | |||
|
|
|||
| def initialize(sourcefile_path=nil) | |||
| @sourcefile_path = sourcefile_path | |||
| @title = sourcefile_path | |||
There was a problem hiding this comment.
Not @title = self.class.title like in cask.rb
This was referenced Mar 4, 2014
Closed
This was referenced Jun 4, 2014
Closed
This was referenced Jun 13, 2014
This was referenced Jun 27, 2014
Closed
This was referenced Jul 14, 2014
Closed
|
Storing metadata is very desirable for the |
This was referenced Aug 18, 2014
Merged
9 tasks
This was referenced Sep 10, 2014
rolandwalker
force-pushed
the
snapshot_caskfiles
branch
from
3e98ff7
to
2da18e0
Compare
rolandwalker
force-pushed
the
snapshot_caskfiles
branch
3 times, most recently
from
881bf73
to
3e281e2
Compare
rolandwalker
added
core
rolandwalker
force-pushed
the
snapshot_caskfiles
branch
from
3e281e2
to
2ac95f4
Compare
Step 2: Snapshot the Cask file used at install-time, using the previously-merged metadata directory support. Using a simple filesystem-is-a-database approach, we set up a `.metadata` directory for each installed Cask in which we can record any information, starting with a copy of the Cask definition which was used at install-time. This should be useful for various cases such as: - a fallback when the Cask was renamed/removed. We currently cannot recover any uninstall info in that scenario - installation of multiple versions of the same software There might be a smarter way to discover the source filename for the Cask through introspection or some deep Ruby voodoo. All I could come up with was to pass the filename in on the constructor, which seems perfectly reasonable if voodoo is not available. The existing code was taking the title as an argument to the constructor, which is dispensable. This PR contains no code to actually make use of the metadata, but only takes care of the relevant book-keeping: creation, destruction, as well as organization of metadata according to software version number and timestamp.
rolandwalker
force-pushed
the
snapshot_caskfiles
branch
from
2ac95f4
to
bf99c6b
Compare
rolandwalker
added a commit
that referenced
this pull request
Dec 11, 2014
Store metadata with installed Casks.
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1: Snapshot the Cask file used at install-time.
Using a simple filesystem-is-a-database approach, set up a
.metadatadirectory for each installed Cask in which we canrecord any information, starting with a copy of the Cask
definition which was used at install-time.
This should be useful for various cases such as:
There might be a smarter way to discover the source filename
for the Cask through introspection or some deep Ruby voodoo.
All I could come up with was to pass the filename in on the
constructor, which seems perfectly reasonable if voodoo is
not available. The existing code was taking the title as an
argument to the constructor, which is dispensable.
This PR contains no code to actually make use of the metadata,
but only takes care of the relevant book-keeping: creation,
destruction, as well as organization of metadata according to
software version number and timestamp.