Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totara - support completion via RPL #59

Open
danmarsden opened this issue Nov 4, 2019 · 1 comment
Open

Totara - support completion via RPL #59

danmarsden opened this issue Nov 4, 2019 · 1 comment

Comments

@danmarsden
Copy link
Member

We need to add support for COMPLETION_COMPLETE_RPL to the Totara branches in the function reengagement_check_target_completion()

https://github.com/catalyst/moodle-mod_reengagement/blob/TOTARA_12/lib.php#L800

@danmarsden
Copy link
Member Author

hmm - this might not be the full picture... the comments in Totara 12 codebase related to that setting state:
TOTARA: This isn't used anywhere in Totara, and hasn't since 2.2.0 at least, so we're going to
// remove it after the release of Totara 10.

I do suspect the code needs updating to get Totara's completion state correctly though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant