Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick BDD AND_GIVEN based macros into Branch Catch1.x #1451

Closed
svdHero opened this issue Nov 21, 2018 · 3 comments
Closed

Cherrypick BDD AND_GIVEN based macros into Branch Catch1.x #1451

svdHero opened this issue Nov 21, 2018 · 3 comments
Labels

Comments

@svdHero
Copy link

svdHero commented Nov 21, 2018

Description

In #1363 the AND_GIVEN macro was added to the master branch.

This seems to be a small change in code with a great benefit for nested BDD style tests. Could this macro be added/cherrypicked to the Catch1.x branch, too? For those of us who are still stuck with Catch1, e.g. due to Visual Studio 2013. :-/

That would be awesome!

@horenmar
Copy link
Member

Sorry, but Catch v1 is very much EOLed. I might be convinced to review and merge a PR, but I am not planning to do the work cherry-picking the changes by myself.

@horenmar horenmar added Query Resolved - pending review Issue waiting for feedback from the original author labels Nov 22, 2018
@svdHero
Copy link
Author

svdHero commented Nov 23, 2018

That makes totally sense. Thank you for being open for a PR. I shall go and try my luck. :)

@horenmar
Copy link
Member

Since it has been almost 4 weeks, I am going to close the issue until further follow-up

@horenmar horenmar removed the Resolved - pending review Issue waiting for feedback from the original author label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants