Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conan to v2 #2700

Closed
nrbnlulu opened this issue Jun 6, 2023 · 4 comments
Closed

update conan to v2 #2700

nrbnlulu opened this issue Jun 6, 2023 · 4 comments
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities Help wanted Issue outside of the maintainers expertise

Comments

@nrbnlulu
Copy link

nrbnlulu commented Jun 6, 2023

Describe the bug
conan warns on deprecated API's usage

WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'cpp_info.filenames' used in: catch2/3.1.0
WARN: deprecated:     'cpp_info.names' used in:  catch2/3.1.0
WARN: deprecated:     'cpp_info.build_modules' used in:  catch2/3.1.0

Expected behavior
No deprecation warnings.

Reproduction steps
try to build a conan project with catch2/3.1.0 as a requirement.

Platform information:

  • OS: Ubuntu 22.0.4
  • Compiler+version:
Ubuntu clang version 14.0.0-1ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
  • Catch version: v3.1.0
@horenmar horenmar added Help wanted Issue outside of the maintainers expertise Building and Packaging Issues affecting build/packaging scripts and utilities labels Jun 8, 2023
@horenmar
Copy link
Member

horenmar commented Jun 8, 2023

I don't use Conan, so the port is community effort -> if someone goes and fixes it up I will merge it.

@LinuxDevon
Copy link
Contributor

LinuxDevon commented Oct 29, 2023

Was looking into fixing this. So two notes I know from playing around with this some:

  1. The build script we have .conan/build.py will need to be updated / changed maybe. See this message for why: https://github.com/conan-io/conan-package-tools#conan-20-support-warning
  2. If we update to conan 2.0 all conan 1.X will break. I am not aware of how to maintain compatibility and think it is just the price we pay for moving up to it.

If I proceed, is there anyone with a little more knowledge on Conan 2? Want to bounce some questions off them. Also not sure the test path here beside ensuring that the test_package works. Is that enough along with the removal of the warnings?

@ChrisThrasher
Copy link
Collaborator

If we update to conan 2.0 all conan 1.X will break. I am not aware of how to maintain compatibility and think it is just the price we pay for moving up to it.

I know it's possible to write Conan recipes compatible with v1 and v2. I don't know the details of how you achieve that though.

@LinuxDevon LinuxDevon mentioned this issue Feb 1, 2024
@LinuxDevon
Copy link
Contributor

I pushed a PR yesterday. It does in fact maintain backwards compatibility. Wasn't too bad but the documentation for conan is not great...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities Help wanted Issue outside of the maintainers expertise
Projects
None yet
Development

No branches or pull requests

4 participants