Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for <=, >= to Approx #651

Closed
jbcoe opened this issue May 4, 2016 · 1 comment · Fixed by #715
Closed

Add support for <=, >= to Approx #651

jbcoe opened this issue May 4, 2016 · 1 comment · Fixed by #715
Labels
Tweak request

Comments

@jbcoe
Copy link
Contributor

jbcoe commented May 4, 2016 •
edited
Loading

Approx is very useful and I'd make further use of it if support for <=, >= could be added.

I'll be happy to do this work.
@jbcoe jbcoe changed the title Add support for <, > to Approx Add support for <=, >= to Approx May 16, 2016
@jbcoe
Copy link
Contributor Author

jbcoe commented May 16, 2016 •
edited
Loading

Updated issue following face-to-face discussion (small world):

I agree that having < and > both true is daft. All the LP and QP libraries I've seen expose <= and >= instead. If Catch did the same and Approx supported <= and >= would that be ok?

@ianmacs ianmacs mentioned this issue Jun 14, 2016
Closed
@jbcoe jbcoe mentioned this issue Sep 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tweak request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for <= and >= for Approx jbcoe/Catch
2 participants
@jbcoe @horenmar