Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Deannotating in the Navigator doesn't update names listed in the Selection Table #2237

Open
acardona opened this issue Oct 11, 2022 · 1 comment
Open

[BUG] Deannotating in the Navigator doesn't update names listed in the Selection Table #2237

acardona opened this issue Oct 11, 2022 · 1 comment
Labels
status: done type: defect

Comments

@acardona
Copy link
Contributor

No description provided.

tomka added a commit that referenced this issue Oct 14, 2022
@tomka
Annotation retrieval: fix modified-since condition to include removal
1e7077c 
Some front-end services like the Neuron Name Service keep track when
they last updated (meta-)annotations and on a refresh() they ask the
back-end to only return results when the annotations changed since the
last update. The back-end SQL implementation of this wasn't working
correctly: it didn't take into account the removal of annotations and
meta-annotations. This is fixed now by also looking at changes in the
past using the history tables. With this in place, the modified-since
check works as expected and e.g. the Neuron Name Service in the
front-end will refresh names correctly when an annotation is removed.

Fixes #2237
@tomka
Copy link
Contributor

tomka commented Oct 14, 2022

Thanks for the bug report Albert! I pushed a fix for this to the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: done type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acardona @tomka