Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networkx 2.x #26

Open
clbarnes opened this issue Jul 23, 2018 · 1 comment
Open

Networkx 2.x #26

clbarnes opened this issue Jul 23, 2018 · 1 comment
Labels

Comments

@clbarnes
Copy link
Collaborator

Old networkx is making some dependencies clash

@clbarnes
Copy link
Collaborator Author

At time of writing, the only place networkx is used is in the export application, to run node_link_graph on JSON data pulled from CATMAID.

In this format, there is an array of nodes, and edges are defined by their source and target nodes.

In networkx 1.x, these nodes are addressed by their index in the nodes array.

In networkx 2.x, these nodes are addressed by their ID.

Whether or not catpy changes, at this point in time, CATMAID currently uses networkx 1.x and so that is the format which will be returned. Obviously the networkx maintainers didn't think to include a schema version in the JSON.

I want networkx 2 so I'll write a converter; catpy will work with either networkx1 or 2 in this instance (more complex graph-manipulating stuff will probably break nx1 compatibility). CATMAID will continue to emit nx1-format JSON, and will break catpy if that changes.

This issue should be left open for informational purposes.

@clbarnes clbarnes changed the title Upgrade to networkx 2.x Networkx 2.x Oct 31, 2018
@clbarnes clbarnes added the done label Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant