Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional dim_inactive option for transparent setups #673

Closed
Lord-Leonard opened this issue Mar 1, 2024 · 2 comments
Closed

Additional dim_inactive option for transparent setups #673

Lord-Leonard opened this issue Mar 1, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Lord-Leonard
Copy link

Lord-Leonard commented Mar 1, 2024

Is your feature request related to a problem? Please describe.
When I set up a transparent setup, I don't like the way inactive windows are displayed. I find it especially hard to make out a popup.
Therefore I would like to use the dim_inactive option. But I, again don't like the harsh contrast between my transparent popup and the now hard background.

without dim
image
hard to spot

with dim
image
this looks awkward as well

Describe the solution you'd like
I would like the background color of inactive windows to still be transparent, but just a little more saturated.

Describe alternatives you've considered
I tried lighten or darken or leaving it as is. I will probably keep dim_inactive off if I cant fix it somehow :/
But I thought I might as well suggest the feature as I absolutely love the work you do and am willing to help make it happen <3

Additional context
I would LOVE this feature, as it would complete my setup in terms of color.
I can dedicate time to development if someone points me in the right direction as to where I would even start :)

@Lord-Leonard Lord-Leonard added the enhancement New feature or request label Mar 1, 2024
@vollowx
Copy link
Collaborator

vollowx commented Aug 11, 2024

@Lord-Leonard First of all, thanks for your love for this project! Unfortunately IMO this is technically impossible for us to implement, because the transparent background is achieved by setting the background to NONE, and what you can see is the raw background of the terminal. So, we are unable to make the transparent part look different - for the background there are only 2 choices:

  1. colored and solid
  2. color removed and transparent

we can't make it colored and transparent.

However, I would like to leave this issue open for the possibility that this may be achieved.

@vollowx vollowx added the help wanted Extra attention is needed label Aug 11, 2024
@jack-mil
Copy link
Contributor

What about changing the saturation of the text foreground colors?
I don't know about what is possible in nvim, but I do know that when I first tried the dim_inactive option, I actually assumed it would be affecting the foreground text color.
I guess I am just used to having transparent background for everything.

@vollowx vollowx closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants