Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whiskers): add rgba to hex helpers #120

Merged
merged 3 commits into from
Feb 13, 2024
Merged

feat(whiskers): add rgba to hex helpers #120

merged 3 commits into from
Feb 13, 2024

Conversation

Anomalocaridid
Copy link
Contributor

Adds helpers to get rgba channels of colors as hex digits:

  • red_h
  • green_h
  • blue_h
  • alpha_h

The helpers each return a pair of hex digits from 00 to FF corresponding to the red, green, blue, and alpha channels respectively.

The rationale behind this is to help with cases where the channels of colors must either be specified separately or in an order other than RRGGBB.

For instance, the video player mpv comes with a plugin that displays stats about the video being played. For some reason, this plugin requires that colors are specified as hex codes in BBGGRR order in its configuration.

@Anomalocaridid Anomalocaridid changed the title Whisker rgb hex helpers feat(whiskers): add helpers that expose rgba components as hex digits Jan 12, 2024
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, just one comment from me!

whiskers/README.md Outdated Show resolved Hide resolved
@sgoudham sgoudham changed the title feat(whiskers): add helpers that expose rgba components as hex digits feat(whiskers): add rgba to hex helpers Feb 13, 2024
@sgoudham sgoudham merged commit 31ffd9e into catppuccin:main Feb 13, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
@Anomalocaridid Anomalocaridid deleted the whisker-rgb-hex-helpers branch February 13, 2024 00:17
@Anomalocaridid Anomalocaridid mentioned this pull request Feb 13, 2024
1 task
sgoudham pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants