feat: add field create_aws_s3_bucket_public_access_block to variable runner_worker_cache
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner_worker_cache` Some organizations may disallow configuring block public access settings on individual S3 buckets. For example, the organization may use account level configuration to block public access on all buckets. To support this, we add the field `create_aws_s3_bucket_public_access_block` to the `runner_worker_cache` variable. We add `count` to the `aws_s3_bucket_public_access_block` resource to control its creation and use the `moved` keyword to ensure that existing instances of this resource are not recreated due to this change.
|
Hey @KevinSnyderCodes! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
KevinSnyderCodes
changed the title
create_aws_s3_bucket_public_access_block to variable runner_worker_cachecreate_aws_s3_bucket_public_access_block to variable runner_worker_cache
KevinSnyderCodes
changed the title
create_aws_s3_bucket_public_access_block to variable runner_worker_cachecreate_aws_s3_bucket_public_access_block to variable runner_worker_cache
kayman-mk
requested changes
Apr 10, 2024
…c_access_block_to_variable_runner_worker_cache
|
Did some quick tests in my environment. Looks good to me. |
kayman-mk
approved these changes
Apr 10, 2024
kayman-mk
requested changes
Apr 10, 2024
added 2 commits
April 10, 2024 14:06
…ock_to_variable_runner_worker_cache' of https://github.com/KevinSnyderCodes/terraform-aws-gitlab-runner into feature/add_field_create_aws_s3_bucket_public_access_block_to_variable_runner_worker_cache
kayman-mk
approved these changes
Apr 11, 2024
kayman-mk
pushed a commit
that referenced
this pull request
Apr 13, 2024
🤖 I have created a release *beep* *boop* --- ## [7.5.0](7.4.0...7.5.0) (2024-04-11) ### Features * add field `create_aws_s3_bucket_public_access_block` to variable `runner_worker_cache` ([#1105](#1105)) ([aa93e76](aa93e76)) ### Bug Fixes * do not deregister GitLab tokens which are still in use ([#1102](#1102)) ([9cdab00](9cdab00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some organizations may disallow configuring block public access settings on individual S3 buckets. For example, the organization may use account level configuration to block public access on all buckets.
To support this, we add the field
create_aws_s3_bucket_public_access_blockto therunner_worker_cachevariable.We add
countto theaws_s3_bucket_public_access_blockresource to control its creation and use themovedkeyword to ensure that existing instances of this resource are not recreated due to this change.Migrations required
No. Migrations are automatically handled by
movedkeyword.Verification
Applied this module with the
create_aws_s3_bucket_public_access_blockfield set tofalse. Theaws_s3_bucket_public_access_blockresource was not created. All other resources were created as expected.