-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Amazon Linux 2023 for runner manager instance #1138
Conversation
Hey @scamp! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
Looks good to me, but I'd like to test it with the "old" AMI. |
Works with the old AMI as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @scamp. Good job!
Please check the PR description. I added a few things. Can we go on with merging?
Co-authored-by: Matthias Kay <[email protected]>
Thanks for review and testing! |
🤖 I have created a release *beep* *boop* --- ## [7.8.0](7.7.0...7.8.0) (2024-06-30) ### Features * use Amazon Linux 2023 for runner manager instance ([#1138](#1138)) ([0412b6d](0412b6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) ## Description Since #1138 was merged, the `runner_gitlab.runner_version` was wrong. The mentioned package `15.8.2` does not exist for Amazon Linux 2023. This PR updates the default version to `16.0.3` the oldest available version. You should never rely on the default value as your Runner has to match the GitLab version. See https://docs.gitlab.com/runner/#gitlab-runner-versions Closes #1147 ## Migrations required Usually not. In case you are still on GitLab < 16 you have to use the old AMI matching `amzn2-ami-hvm-2.*-x86_64-ebs` (used before #1138 was merged). Then you are able to still use an older version of the Runner. ## Verification - verified that `16.0.3` is available. Installation is done via ``` curl --fail --retry 6 -L https://packages.gitlab.com/install/repositories/runner/gitlab-runner/script.rpm.sh | bash yum install gitlab-runner-${gitlab_runner_version} -y ```
Description
Adds support for Amazon Linux 2023 and removes the
dmesg
logs from Cloudwatch as it wasn't useful at all.Closes #1137