Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Amazon Linux 2023 for runner manager instance #1138

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

scamp
Copy link
Contributor

@scamp scamp commented Jun 24, 2024

Description

Adds support for Amazon Linux 2023 and removes the dmesg logs from Cloudwatch as it wasn't useful at all.

Closes #1137

  • GitlabRunner is operating
  • Cloudwatch logs are populated
  • jobs form GitLab are processed
  • no errors in log files found
  • also works with the old default AMI (Amazon Linux 1 and 2)

Copy link
Contributor

Hey @scamp! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@scamp scamp changed the title Use Amazon Linux 2023 for runner manager instance. Closes #1137 fix: Use Amazon Linux 2023 for runner manager instance. Closes #1137 Jun 24, 2024
@scamp scamp changed the title fix: Use Amazon Linux 2023 for runner manager instance. Closes #1137 fix: use Amazon Linux 2023 for runner manager instance. Closes #1137 Jun 24, 2024
@kayman-mk
Copy link
Collaborator

Looks good to me, but I'd like to test it with the "old" AMI.

@kayman-mk kayman-mk changed the title fix: use Amazon Linux 2023 for runner manager instance. Closes #1137 feat: use Amazon Linux 2023 for runner manager instance Jun 27, 2024
@kayman-mk
Copy link
Collaborator

Works with the old AMI as well.

kayman-mk
kayman-mk previously approved these changes Jun 27, 2024
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @scamp. Good job!

Please check the PR description. I added a few things. Can we go on with merging?

variables.tf Outdated Show resolved Hide resolved
template/logging.tftpl Show resolved Hide resolved
Co-authored-by: Matthias Kay <[email protected]>
@scamp
Copy link
Contributor Author

scamp commented Jun 27, 2024

Thanks for review and testing!
I believe its ready for merging now.

@scamp scamp requested a review from kayman-mk June 27, 2024 12:26
@kayman-mk kayman-mk merged commit 0412b6d into cattle-ops:main Jun 30, 2024
19 checks passed
kayman-mk pushed a commit that referenced this pull request Jul 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.8.0](7.7.0...7.8.0)
(2024-06-30)


### Features

* use Amazon Linux 2023 for runner manager instance
([#1138](#1138))
([0412b6d](0412b6d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kayman-mk added a commit that referenced this pull request Jul 22, 2024
)

## Description

Since #1138 was merged, the `runner_gitlab.runner_version` was wrong.
The mentioned package `15.8.2` does not exist for Amazon Linux 2023.
This PR updates the default version to `16.0.3` the oldest available
version.

You should never rely on the default value as your Runner has to match
the GitLab version. See
https://docs.gitlab.com/runner/#gitlab-runner-versions

Closes #1147 

## Migrations required

Usually not. In case you are still on GitLab < 16 you have to use the
old AMI matching `amzn2-ami-hvm-2.*-x86_64-ebs` (used before #1138 was
merged). Then you are able to still use an older version of the Runner.

## Verification

- verified that `16.0.3` is available. Installation is done via
```
  curl --fail --retry 6 -L https://packages.gitlab.com/install/repositories/runner/gitlab-runner/script.rpm.sh | bash
  yum install gitlab-runner-${gitlab_runner_version} -y
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Amazon Linux 2023
3 participants