Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct names for autoscaler policies configuration #1167

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

kayman-mk
Copy link
Collaborator

Description

PascalCase was used to create the [[runners.autoscaler.policy]] which is wrong according to the documentation. This PR fixes the names in the configuration file. IdleCount --> idle_count

The worker instances were used once and then terminated. This resulted in a high load of some AWS autoscaling APIs and we got rate limiting. In the end most pipelines failed.

Verification

Deployed the changes into my environment. The worker machines are reused now.

@kayman-mk kayman-mk requested a review from npalm as a code owner August 6, 2024 09:10
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@kayman-mk kayman-mk changed the title fix: use correct names for autoscaler policies fix: use correct names for autoscaler policies configuration Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.57s
✅ REPOSITORY checkov yes no 15.99s
✅ REPOSITORY dustilock yes no 0.23s
✅ REPOSITORY gitleaks yes no 1.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.25s
✅ REPOSITORY secretlint yes no 0.99s
✅ REPOSITORY syft yes no 0.35s
✅ REPOSITORY trivy-sbom yes no 1.1s
✅ REPOSITORY trufflehog yes no 6.15s
✅ SPELL cspell 2 0 2.57s
✅ TERRAFORM terraform-fmt 1 0 0 0.11s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 8b31986 into main Aug 6, 2024
20 checks passed
@kayman-mk kayman-mk deleted the kayma/fix-autoscaler-names branch August 6, 2024 09:13
kayman-mk pushed a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.12.1](7.12.0...7.12.1)
(2024-08-06)


### Bug Fixes

* use correct names for autoscaler policies configuration
([#1167](#1167))
([8b31986](8b31986))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant