Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add " to the new update_interval_* options of the autoscaler #1177

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

kayman-mk
Copy link
Collaborator

Description

The new options update_interval and update_interval_when_expecting are strings and need a " around the value. Otherwise the configuration file has the wrong format and the Agent might not work as expected.

Closes #1176

@kayman-mk kayman-mk requested a review from npalm as a code owner August 22, 2024 07:51
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.51s
✅ REPOSITORY checkov yes no 15.06s
✅ REPOSITORY dustilock yes no 0.33s
✅ REPOSITORY gitleaks yes no 1.32s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY grype yes no 12.89s
✅ REPOSITORY secretlint yes no 1.04s
✅ REPOSITORY syft yes no 0.44s
✅ REPOSITORY trivy-sbom yes no 1.0s
✅ REPOSITORY trufflehog yes no 4.29s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit e792256 into main Aug 22, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayman-mk-patch-1 branch August 22, 2024 07:54
kayman-mk pushed a commit that referenced this pull request Aug 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.13.1](7.13.0...7.13.1)
(2024-08-22)


### Bug Fixes

* add `"` to the new `update_interval_*` options of the autoscaler
([#1177](#1177))
([e792256](e792256)),
closes
[#1176](#1176)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need quotes for update_interval and update_interval_when_expecting config values
1 participant