Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove deprecated pull policy variable #710

Conversation

tmeijn
Copy link
Contributor

@tmeijn tmeijn commented Feb 25, 2023

Description

Removes the earlier deprecated runners_pull_policy variable. Since were making a Major release I thought this one was nice to catch.

Migrations required

YES. Replace the runners_pull_policy by runners_pull_policies.

Verification

I have not verified: this change seems small enough to not warrant it. Let me know if you disagree.

@github-actions
Copy link
Contributor

Hey @tmeijn! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you have the rights of the code added and agree that it will published under the MIT license.

This message was generated automatically. You are welcome to improve it.

@tmeijn tmeijn changed the title fix: remove deprecated pull policy variable fix!: remove deprecated pull policy variable Feb 25, 2023
@tmeijn tmeijn marked this pull request as ready for review February 25, 2023 19:18
@kayman-mk kayman-mk added this to the v7.0.0 Rework variables milestone Feb 26, 2023
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The first PR in a series of others. Planned for v7.0.0.

@kayman-mk kayman-mk changed the base branch from main to refactor-variables March 2, 2023 08:24
@kayman-mk kayman-mk merged commit 235e81f into cattle-ops:refactor-variables Mar 2, 2023
kayman-mk pushed a commit that referenced this pull request Mar 2, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Mar 13, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Mar 16, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Mar 23, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Apr 20, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Apr 20, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Apr 27, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request May 3, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request May 11, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Jun 1, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Jun 15, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Jul 6, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Jul 6, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Sep 7, 2023
## Description

Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch.

## Migrations required

YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
kayman-mk pushed a commit that referenced this pull request Sep 10, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](6.5.2...7.0.0)
(2023-09-09)


### ⚠ BREAKING CHANGES

* group variables for better overview
([#810](#810))
* allow to set all docker options for the Executor
([#511](#511))
* add idle_count_min` and `idle_scale_factor` to Docker Machine
autoscaling options
([#711](#711))
* remove deprecated variables
([#738](#738))
* remove deprecated pull policy variable
([#710](#710))

### Features

* add idle_count_min` and `idle_scale_factor` to Docker Machine
autoscaling options
([#711](#711))
([1538d48](1538d48))
* allow to set all docker options for the Executor
([#511](#511))
([461561e](461561e))


### Bug Fixes

* add missing defaults
([#905](#905))
([eb44182](eb44182))
* correct the bugs of major version 7 (pre-release)
([#860](#860))
([f236b58](f236b58))
* remove deprecated pull policy variable
([#710](#710))
([8736ec7](8736ec7))


### Miscellaneous Chores

* remove deprecated variables
([#738](#738))
([676ed6a](676ed6a))


### Code Refactoring

* group variables for better overview
([#810](#810))
([c8a3b89](c8a3b89))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Niek Palm <[email protected]>
Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants