Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correctly format prefix #735

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

NeelChotai
Copy link
Contributor

@NeelChotai NeelChotai commented Mar 8, 2023

Description

At the moment the launch template and autoscaling group aren't formatted correctly. This fix will correct the display names.

Requires recreation of the asg but this is likely fine.

Migrations required

NO

Verification

e.g. environment20230207121641923900000006-asg -> environment-20230207121641923900000006-asg

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Hey @NeelChotai! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you have the rights of the code added and agree that it will published under the MIT license.

This message was generated automatically. You are welcome to improve it.

@kayman-mk kayman-mk changed the title fix: correctly format prefix refactor: correctly format prefix Mar 9, 2023
@kayman-mk
Copy link
Collaborator

Thanks for your contribution, @NeelChotai Appreciated!

I changed the prefix in the title of the PR as this change does not fix a bug in the module.

@kayman-mk kayman-mk merged commit 76f2770 into cattle-ops:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants