Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues #39

Open
notlmn opened this issue Mar 24, 2020 · 0 comments
Open

Fix CI issues #39

notlmn opened this issue Mar 24, 2020 · 0 comments
Labels
good first issue help wanted under discussion

Comments

@notlmn
Copy link
Member

notlmn commented Mar 24, 2020

Take a look at Lighthouse logs for the current build on GitHub Actions and start from there.

Our target scores under each section are:

  • Accessibility: 70% (should crank this up to 80%)
  • Performance: 85% (should ideally be 90%)
  • SEO: 70% (Can crank up to 85%, we are already at 87%)
  • Best Practices: 70% (should ideally be 90%, we are already at 93%)

Perform respective changes (image compression and optimization, a11y changes, ...), and increase minimum score targets in test/checklog.js.

Reach out to me (@notlmn) or @r0mflip for any issues or (potentially silly) questions, we won't bite. 😉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted under discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notlmn