Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Setaria simulations at transect sites #986

Closed
2 of 3 tasks
Aariq opened this issue Jul 14, 2022 · 6 comments
Closed
2 of 3 tasks

Run Setaria simulations at transect sites #986

Aariq opened this issue Jul 14, 2022 · 6 comments
Assignees

Comments

@Aariq
Copy link
Member

Aariq commented Jul 14, 2022

  • Slack Julian about permissions on Welsch
  • Merge Kristina's PR
  • Run the rest of the sites with site-relevant PFTs and weather
  • Ask German if he wants to meet and work through any of this together.
@Aariq Aariq self-assigned this Jul 14, 2022
@Aariq
Copy link
Member Author

Aariq commented Jul 14, 2022

I can't do this in the most correct way until I get the permissions issues on Welsch worked out.

@Aariq
Copy link
Member Author

Aariq commented Jul 18, 2022

Notes:

  • Need write access to data/dbfiles/posterior?
  • Check Vcmax posteriors with @dlebauer or @KristinaRiemer—they don't look right to me.
  • How to deal with lack of convergence in meta analysis?

@dlebauer
Copy link
Contributor

First place I’d look is the vcmax meta analysis summary figures that have the prior and posterior pdfs + rug plot of data

Usually lack of convergence in PEcAn MA indicates an issue with the data and / or priors

@Aariq
Copy link
Member Author

Aariq commented Jul 21, 2022

Yeah, I think there's a problem with the priors for vcmax. This is from one of Kristina's runs:
Screen Shot 2022-07-21 at 1 06 27 PM

I don't know what 'approx' is, but the prior seems bounded incorrectly

@dlebauer
Copy link
Contributor

"approx" is a parameterized distribution fit to the posterior, e.g. a normal with mean and sd of the MCMC samples. Next step is to figure out why the prior and data are inconsistent.

Sometimes this points to an error in the data - some examples include

  • it entered with the correct units,
  • conversions done incorrectly
  • With Vcmax, there is a leaf temperature covariate that is used in conversion; this should be correct

It could also be an issue with the prior - too narrow, built with too few samples, estimated from traits of wild plants not applicable to crops, or measurements from a growth chamber or greenhouse will be very different. This should be accounted for in the model with the greenhouse fixed effect, but might not be estimated if there is only data from chambers

Which PFT is this? If it is Setaria, I'd be curious if we have encountered this before, if not why not. Would be good to check in with @jessicaguo who I think entered many of the Setaria Vcmax data.

@Aariq
Copy link
Member Author

Aariq commented Jul 22, 2022

This is SetariaWT. It looks like this in all of a haphazard sample of the runs in /data/tests/

This was referenced Jul 26, 2022
@Aariq Aariq closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants