Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ancillary and garbage support for .real parser #88

Open
burgholzer opened this issue Apr 22, 2022 · 0 comments · May be fixed by #635
Open

Ancillary and garbage support for .real parser #88

burgholzer opened this issue Apr 22, 2022 · 0 comments · May be fixed by #635
Labels
Core Anything related to the Core library and IR enhancement New feature or request

Comments

@burgholzer
Copy link
Member

At the moment, the .real file parser (see https://github.com/cda-tum/qfr/blob/main/src/parsers/RealParser.cpp) does not handle constant or garbage definitions properly.
This has not been particularly important up until now, since we typically just consider the whole state vector during simulation (e.g., in cda-tum/ddsim#main) and similarly the complete functionality for equivalence checking.
However, it might become important in the future for our endeavours towards reversible circuits.

In particular,

  • any constant should be properly flagged as an ancillary qubit in the resulting QuantumComputation.
  • any garbage should be properly flagged as a garbage qubit in the resulting QuantumComputation.
  • the inputs and outputs could be used to determine the initial_layout and the output_permutation respectively. Although, it is not so clear whether this is possible for any .real file.
@burgholzer burgholzer added the enhancement New feature or request label Apr 22, 2022
@burgholzer burgholzer added the Core Anything related to the Core library and IR label Jun 15, 2023
@TooMuchDakka TooMuchDakka linked a pull request Jun 25, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR enhancement New feature or request
Projects
Status: Todo
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant