Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk documentation doesn't recommend to put VteTerminal in a scrolledWindow #114

Open
dakotaclemenceplaza opened this issue Jun 26, 2019 · 1 comment
Labels
beginner-friendly Good for newcomers enhancement New feature or request help wanted Extra attention is needed

Comments

@dakotaclemenceplaza
Copy link
Contributor

The description here https://developer.gnome.org/vte/0.48/VteTerminal.html says

Note that altough VteTerminal implements the GtkScrollable interface, you should not place a VteTerminal inside a GtkScrolledWindow container, since they are incompatible. Instead, pack the terminal in a horizontal GtkBox together with a GtkScrollbar which uses the GtkAdjustment returned from gtk_scrollable_get_vadjustment().

It seems that termonad does exactly that. I guess it's better to change it to recommended way?

@cdepillabout cdepillabout added beginner-friendly Good for newcomers enhancement New feature or request help wanted Extra attention is needed labels Jun 26, 2019
@cdepillabout
Copy link
Owner

@dakotaclemenceplaza Good catch.

Here's the function that creates the ScrolledWindow and adds the Terminal to it:

createTerm :: (TMState -> EventKey -> IO Bool) -> TMState -> IO TMTerm

This should probably be changed to instead do as the documentation above says.


That said, this hasn't seemed to cause any big bugs in Termonad, so this isn't super high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly Good for newcomers enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants