Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all node configuration to constructor #1

Open
lordjabez opened this issue May 23, 2022 · 0 comments
Open

Move all node configuration to constructor #1

lordjabez opened this issue May 23, 2022 · 0 comments

Comments

@lordjabez
Copy link
Contributor

Due to an issue with CDK (aws/aws-cdk#18237) the permissions around the AwsCustomResource used to perform Hyperledger functions have to be broader than necessary, and not scoped to the constructs where they're used.

When the CDK bug is fixed, the code here can be cleaned up accordingly, see https://github.com/cdklabs/cdk-hyperledger-fabric-network/blob/main/src/network.ts#L353-L365. Specifically the nodes can completely set themselves up in their constructor and not require a subsequent call, and the permissions can be moved out of network.ts.

@lordjabez lordjabez changed the title Centralize Move all node configuration to constructor Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant