Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup equalizer presets and filters #235

Merged
merged 26 commits into from
Jul 29, 2024
Merged

feat: setup equalizer presets and filters #235

merged 26 commits into from
Jul 29, 2024

Conversation

cdrani
Copy link
Owner

@cdrani cdrani commented Jul 28, 2024 •
edited
Loading

Add EQ presets:

  1. Same presets as in Spotify desktop/mobile apps. I can't guarantee the sound is a 100% match, but it should be almost indistinguishable. Might have some soft crackling. Will need investigate to remedy (if possible)
  2. Custom presets generated for missing genres, environments, etc

image

closes #234

cdrani added 21 commits July 26, 2024 15:10
@cdrani
feat: setup equalizer presets and filters
3299bab
@cdrani
feat: Equalizer model to (dis)connect eq effect
faf4cae
@cdrani
feat: connect Equalizer to video instance
8947ea8
@cdrani
docs: add license field to package.json
a7507cd
@cdrani
refactor: extract selector creator into component
79ac366
@cdrani
feat: add eq ui in header
cf58dc2
@cdrani
styles: allow selector width to stretch
7c1558a
@cdrani
styles: expand chorus ui to fit eq header
a31c438
@cdrani
feat: store methods to set & get equalizer state
9f12094
@cdrani
feat: add more EQ presets & filters
c0284ee
@cdrani
feat: setup equalizer ui builder
7c417d4
@cdrani
feat: extract shared AudioManager
56f4ef6
@cdrani
feat: use audio manager in equalizer & reverb
1fbb75d
@cdrani
refactor: pass single arg to App class
bf50d4f
@cdrani
feat: set/disconnect on equalizer on enabled
a35852c
@cdrani
feat: add listeners for equalizer buttons & views
bf7a527
@cdrani
feat: add equalizer controller for eq view
0b5612e
@cdrani
refactor: update reverb ui selection element id
87839ea
@cdrani
refactor: split eq presets into spotify & custom
18d0f9c
@cdrani
refactor: split eq into spotify & custom selectors
4050d68
@cdrani
chore: remove _effect in reverb + eq models
8312106
@cdrani cdrani added the enhancement New feature or request label Jul 28, 2024
@cdrani cdrani self-assigned this Jul 28, 2024
@cdrani cdrani merged commit 25a9289 into develop Jul 29, 2024
@cdrani cdrani deleted the feat/equalizer-presets branch July 29, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdrani cdrani

Labels
enhancement New feature or request
Projects
Chorus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEAT: Equalizer Presets
1 participant
@cdrani