[Bug]: Now Playing Icon Needs To Be Accessible #56
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Describe the bug
We are currently using a div instead of a button as the parent of the settings icon in the Now Playing Widget. This is not semantically correct and has poor accessibility (a11y). We need to replace the div with a button.
Expected behavior
It should have similar accessible properties as displayed for the heart button and the settings icon on a tracklist/playlist/album track
Additional context
Now Playing Icon file: https://github.com/cdrani/chorus/blob/develop/models/icon.js
Example to reference:
chorus/models/snip-icon.js
Lines 22 to 47 in 11ee050
Some changes to styles might need to be made to keep the same UI. For example, the
visibility
attribute does not need to be set as it should always be visible, or the styles coming from thechorus-icon
id might need to be updated. Use your discretion and get it as close as possible to the current UI, but just with replacing the div with a button. The a11y portion should transfer over with using the same attributes (role, aria-label, etc) currently on the div and some just based on the button element.The text was updated successfully, but these errors were encountered: