Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playback rate #76

Merged
merged 28 commits into from
Aug 27, 2023
Merged

feat: playback rate #76

merged 28 commits into from
Aug 27, 2023

Conversation

cdrani
Copy link
Owner

@cdrani cdrani commented Aug 27, 2023

  1. Setup Speed UI to set global and track playback rates. Additionally, users can also toggle presrvesPitch property of the video HTMLMediaElement
image
  1. On song change update the HTMLMediaElement playbackRate & preservesPitch values based on either the current tracks saved values (if set) or the global values.

  2. Toggling on/off the action icon toggles the speed functionality.

  3. Finally (🤞) fix the Spotify connect issue where on device switch the extensions UI disappears and a page reload is required to restore it.

closes #9

@cdrani cdrani merged commit e51b3fb into develop Aug 27, 2023
@cdrani cdrani deleted the feat/playback-rate branch August 27, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback Rate
1 participant