fix: remove custom health check metrics

[patheard]

Summary

Remove the CloudWatch custom health check metrics to save costs. The service health dashboard will be updated to generate its graphs via log insight queries.

Related

• Smoke tests for production releases platform-forms-client#3585

[github-actions]

⚠ Terrform update available

Terraform: 1.8.5 (using 1.6.6)
Terragrunt: 0.59.4 (using 0.54.8)

[github-actions]

Staging: alarms

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 0 to add, 0 to change, 18 to destroy

Show summary

CHANGE	NAME
delete	aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverWarn"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilitySuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityWarn"]
	aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverWarn"]
	aws_cloudwatch_log_metric_filter.healthcheck["SubmissionFailed"]
	aws_cloudwatch_log_metric_filter.healthcheck["SubmissionSuccess"]
	aws_cloudwatch_log_metric_filter.healthcheck["SubmissionWarn"]

Show plan

Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ClientSubmitFailed" -> null
      - log_group_name = "Forms" -> null
      - name           = "ClientSubmitFailed" -> null
      - pattern        = "Attempted response submission for Form ID" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ClientSubmitFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ClientSubmitSuccess" -> null
      - log_group_name = "Forms" -> null
      - name           = "ClientSubmitSuccess" -> null
      - pattern        = "Response submitted for Form ID" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ClientSubmitSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "FormArchiverFailed" -> null
      - log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
      - name           = "FormArchiverFailed" -> null
      - pattern        = "{$.status = \"failed\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "FormArchiverFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "FormArchiverSuccess" -> null
      - log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
      - name           = "FormArchiverSuccess" -> null
      - pattern        = "{$.status = \"success\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "FormArchiverSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverWarn"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "FormArchiverWarn" -> null
      - log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
      - name           = "FormArchiverWarn" -> null
      - pattern        = "{$.level = \"warn\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "FormArchiverWarn" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityFailed" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityFailed" -> null
      - pattern        = "{$.status = \"failed\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityNotifySendFailed" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityNotifySendFailed" -> null
      - pattern        = "Failed to send submission through GC Notify" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityNotifySendFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityNotifySendSuccess" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityNotifySendSuccess" -> null
      - pattern        = "Successfully sent submission through GC Notify" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityNotifySendSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilitySuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilitySuccess" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilitySuccess" -> null
      - pattern        = "{$.status = \"success\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilitySuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityVaultSaveFailed" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityVaultSaveFailed" -> null
      - pattern        = "Failed to save submission to Vault" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityVaultSaveFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityVaultSaveSuccess" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityVaultSaveSuccess" -> null
      - pattern        = "Successfully saved submission to Vault" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityVaultSaveSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityWarn"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ReliabilityWarn" -> null
      - log_group_name = "/aws/lambda/Reliability" -> null
      - name           = "ReliabilityWarn" -> null
      - pattern        = "{$.level = \"warn\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ReliabilityWarn" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ResponseArchiverFailed" -> null
      - log_group_name = "/aws/lambda/Response_Archiver" -> null
      - name           = "ResponseArchiverFailed" -> null
      - pattern        = "{$.status = \"failed\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ResponseArchiverFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ResponseArchiverSuccess" -> null
      - log_group_name = "/aws/lambda/Response_Archiver" -> null
      - name           = "ResponseArchiverSuccess" -> null
      - pattern        = "{$.status = \"success\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ResponseArchiverSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverWarn"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "ResponseArchiverWarn" -> null
      - log_group_name = "/aws/lambda/Response_Archiver" -> null
      - name           = "ResponseArchiverWarn" -> null
      - pattern        = "{$.level = \"warn\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "ResponseArchiverWarn" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["SubmissionFailed"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "SubmissionFailed" -> null
      - log_group_name = "/aws/lambda/Submission" -> null
      - name           = "SubmissionFailed" -> null
      - pattern        = "{$.status = \"failed\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "SubmissionFailed" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["SubmissionSuccess"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "SubmissionSuccess" -> null
      - log_group_name = "/aws/lambda/Submission" -> null
      - name           = "SubmissionSuccess" -> null
      - pattern        = "{$.status = \"success\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "SubmissionSuccess" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

  # aws_cloudwatch_log_metric_filter.healthcheck["SubmissionWarn"] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
      - id             = "SubmissionWarn" -> null
      - log_group_name = "/aws/lambda/Submission" -> null
      - name           = "SubmissionWarn" -> null
      - pattern        = "{$.level = \"warn\"}" -> null

      - metric_transformation {
          - default_value = "0" -> null
          - dimensions    = {} -> null
          - name          = "SubmissionWarn" -> null
          - namespace     = "forms" -> null
          - unit          = "Count" -> null
          - value         = "1" -> null
        }
    }

Plan: 0 to add, 0 to change, 18 to destroy.

Warning: Argument is deprecated

  with module.athena_bucket.aws_s3_bucket.this,
  on .terraform/modules/athena_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
   8: resource "aws_s3_bucket" "this" {

Use the aws_s3_bucket_server_side_encryption_configuration resource instead

(and 3 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.codedeploy_sns"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notify_slack"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ELB_5xx_error_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup1"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup2"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.audit_log_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_login_outside_canada_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_signin_exceeded"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ddos_detected_forms_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ddos_detected_route53_warn[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.forms_cpu_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.forms_memory_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.reliability_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.response_time_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.route53_ddos[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.twoFa_verification_exceeded"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.vault_data_integrity_check_lambda_iterator_age"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.notify_slack_lambda"]
WARN - plan.json -...