Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase the number of form viewer tasks in prod #717

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

patheard
Copy link
Member

@patheard patheard commented Jul 4, 2024

Summary

Update the number of form viewer tasks running in production. Also lower the CPU and memory use thresholds to cause scaling events to happen sooner.

The new thresholds were selected by evaluating the ECS task's resource use over the past 6 weeks:

image

⚠️ Note

The increased ECS task count will only apply to Production to save costs.

Update the number of form viewer tasks running in production.  Also lower the
CPU and memory use thresholds to cause scaling events to happen sooner.

The new thresholds were selected by evaluating the ECS task's resource
use over the past 6 weeks.
@patheard patheard self-assigned this Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

⚠ Terrform update available

Terraform: 1.9.1 (using 1.6.6)
Terragrunt: 0.59.6 (using 0.54.8)

Copy link

github-actions bot commented Jul 4, 2024

Staging: app

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 2 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_appautoscaling_policy.forms_cpu[0]
aws_appautoscaling_policy.forms_memory[0]
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_appautoscaling_policy.forms_cpu[0] will be updated in-place
  ~ resource "aws_appautoscaling_policy" "forms_cpu" {
        id                 = "forms_cpu"
        name               = "forms_cpu"
        # (6 unchanged attributes hidden)

      ~ target_tracking_scaling_policy_configuration {
          ~ target_value       = 60 -> 25
            # (3 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

  # aws_appautoscaling_policy.forms_memory[0] will be updated in-place
  ~ resource "aws_appautoscaling_policy" "forms_memory" {
        id                 = "forms_memory"
        name               = "forms_memory"
        # (6 unchanged attributes hidden)

      ~ target_tracking_scaling_policy_configuration {
          ~ target_value       = 60 -> 15
            # (3 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

Plan: 0 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_appautoscaling_target.forms[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_app.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_deployment_group.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_cluster.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_service.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_task_definition.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.cognito"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_dynamodb"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_kms"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_s3"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_secrets_manager"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_sqs"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.codedeploy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.forms"]

34 tests, 19 passed, 15 warnings, 0 failures, 0 exceptions

Copy link
Contributor

@craigzour craigzour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patheard patheard merged commit 0a252de into develop Jul 4, 2024
11 checks passed
@patheard patheard deleted the feat/more-ecs-tasks branch July 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants