Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unrequired env var #2864

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

bryan-robitaille
Copy link
Contributor

@bryan-robitaille bryan-robitaille commented Nov 16, 2023

Summary | Résumé

Following the same pattern in the application for the other Lambda function calls by referencing a hardcoded value.

Simplifies the Infra as Code by not having to pass in an additional value that is already known.

Test instructions | Instructions pour tester la modification

  • Submit a form
  • Everything should submit a-ok

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

In the tv show Loki how could you reach 'the end of time' when time itself is an infinite scaling problem.

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Copy link
Contributor

@bryan-robitaille bryan-robitaille enabled auto-merge (squash) November 16, 2023 19:12
@bryan-robitaille bryan-robitaille merged commit 7002111 into develop Nov 16, 2023
11 checks passed
@bryan-robitaille bryan-robitaille deleted the chore/remove_unneeded_env branch November 16, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants