-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move share button #3103
chore: Move share button #3103
Conversation
🧪 Review environmenthttps://7hl4k35htzg2vyidtp7tqvm6va0hiuqk.lambda-url.ca-central-1.on.aws/ |
e95b718
to
54cc226
Compare
2d04130
to
6bb1aa5
Compare
…forms-client into chore/3059-save-button
One minor change. It would be helpful to have focus placed on the "Failed - Contact support" after the error is shown. Currently looking to see how difficult that would be |
That could. be difficult. I think we need to refactor StyleLink to receive a ref for the error link. Then in a useEffect, if there is an error, focus that ref. There may be other ways. If we were to go this route, the code change may impact other parts of the app, so probably best to do outside this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to revisit the Toast for this and similar use cases in a future task. Also the the comment about focussing the error link but as mentioned, that's probably best to do in a separate PR.
Nice work, LGTM :)
@thiessenp-cds I attempted to use a ref + use effect on the title inside the toast notification but it didn't seem to be working. Agreed we could do some further work under a future PR. |
…forms-client into chore/3059-save-button
Co-authored-by: Anik Brazeau <[email protected]>
Co-authored-by: Anik Brazeau <[email protected]>
Co-authored-by: Anik Brazeau <[email protected]>
Co-authored-by: Anik Brazeau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM :)
Fixes: #3059