fix: update template subscribe #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://ojgsjk2hwvbc7hyy5zod2m7egm0ixrit.lambda-url.ca-central-1.on.aws/ |
timarney
changed the title
thiessenp-cds
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Nice, my first thought was to test to see if translations were also updating the "save" button. That's working well and the updates are still being announced for a screen reader well. My only thought looking through the code was that if the state compare logic becomes more complicated a reducer might help. But right, LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Fixes #3112
Update to monitor changes to description fields and force provider to re-render to make the save button available.