Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename NEXTAUTH_URL as it is no longer required for Next-Auth #3288

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

bryan-robitaille
Copy link
Contributor

@bryan-robitaille bryan-robitaille commented Feb 27, 2024

Summary | Résumé

Renames the NEXTAUTH_URL parameter to HOST_URL as it is used in other parts of the application.

Future versions of Next-Auth (v5) have an issue when the NEXTAUTH_URL is present. Our current version (V4) does not explicitly require the NEXTAUTH_URL and can operate without it.

Infrastructure Dependency: cds-snc/forms-terraform#606

Test instructions | Instructions pour tester la modification

  • Rename the NEXTAUTH_URL in you .env file to HOST_ENV
  • Run the app with yarn dev or yarn build && yarn start

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Copy link
Contributor

@bryan-robitaille bryan-robitaille merged commit 6ea5064 into develop Feb 27, 2024
11 checks passed
@bryan-robitaille bryan-robitaille deleted the chore/remove_nextauth_url branch February 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants