Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Treeview Drag/Drop fixes #3722

Merged
merged 10 commits into from
May 31, 2024
Merged

Fix: Treeview Drag/Drop fixes #3722

merged 10 commits into from
May 31, 2024

Conversation

dsamojlenko
Copy link
Member

@dsamojlenko dsamojlenko commented May 30, 2024 •
edited
Loading

Summary | Résumé

  • Render item container as Div so that the Delete icon can be a button
  • Bugfix: Prevent drop after Review when there are open groups
  • Truncate long Item titles
  • Render custom dragBetweenLine (target)
  • Allow dropping items on folders (prop + canDropAt handler)
  • Allow dropping items and folders below open folders (prop)
  • Eliminate dragBetweenLine "drift"

@github-actions GitHub Actions
Copy link
Contributor

🧪 Review environment

https://ttq64n54rqqpmi3zhl3lywwjmm0bsqav.lambda-url.ca-central-1.on.aws/

@dsamojlenko dsamojlenko marked this pull request as ready for review May 31, 2024 19:03
@dsamojlenko dsamojlenko enabled auto-merge (squash) May 31, 2024 19:03
@dsamojlenko dsamojlenko merged commit fed32fe into develop May 31, 2024
13 checks passed
@dsamojlenko dsamojlenko deleted the fix/tree-view-drag-target branch May 31, 2024 19:08
@sre-read-write sre-read-write bot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timarney timarney timarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsamojlenko @timarney