Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mfa resend when no session #3808

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix: mfa resend when no session #3808

merged 2 commits into from
Jun 11, 2024

Conversation

bryan-robitaille
Copy link
Contributor

Summary | Résumé

take 2 of #3801

Updates the handling of 2fa "resend code" path errors.

Adds a log entry that identifies the email address trying to request a new token {"level":"warn","time":1718129549075,"msg":"Failed to send new verification code. Reason: Missing 2FA session for user [email protected]."}
Fixes the error path to ensure the server redirects the user to /auth/login if a session does not exist instead of relying on the browser. In NODE_ENV Production the error was being sanitized and wasn't being properly handled client side.

Also modifies the "form submission" event log to identify that it is a form submission and not just listing the form ID.

@bryan-robitaille bryan-robitaille changed the title Fix/mfa resend Fix: mfa resend when no session Jun 11, 2024
Copy link
Contributor

Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM :)

@bryan-robitaille bryan-robitaille merged commit 496e360 into develop Jun 11, 2024
13 checks passed
@bryan-robitaille bryan-robitaille deleted the fix/mfa_resend branch June 11, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants