Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Email Delivery Component was mistakenly async #3961

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

bryan-robitaille
Copy link
Contributor

Summary | Résumé

Fixes error when trying to access Responses page when delivery option is set to Email

Screenshot 2024-07-05 at 10 57 30 AM

Test instructions | Instructions pour tester la modification

  1. Go to unpublished form
  2. Change delivery settings to email
  3. Go to Responses page
  4. The responses page should show that you have email delivery enabled.

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

Are there any related issues or tangent features you consider out of scope for
this issue that could be addressed in the future? If so please create issues and provide
links in this section

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Copy link
Contributor

@craigzour craigzour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I tested it locally and it does fix the issue. I had narrowed it down to the DeliveryOptionEmail component so it makes perfect sense to see a fix in there ;)

@bryan-robitaille bryan-robitaille changed the title set to client component instead of server fix: Email Delivery Component was mistakenly async Jul 5, 2024
@bryan-robitaille bryan-robitaille merged commit 84f0b1c into develop Jul 5, 2024
13 checks passed
@bryan-robitaille bryan-robitaille deleted the fix/repsonses_page_hanging branch July 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants