-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Review page" from single-page forms as it is redundant #4075
Comments
I thought about this for a bit and I think it makes sense. A user on a single page form can skim their filled in answers on that page. The current behavior is to only show the Review page if Conditional Logic is enabled. This task would add on to that, to only show the Review page if a form has groups (multiple pages). Does that sound right? |
Do we know what the behaviour would be for single-page existing forms that have already been published once conditional logic is released? |
What if there was an option to "Skip Review page" ? |
I've validated that the Review Page will not show up for existing Published Forms that we have in GC Forms, once we flick the feature flag On.
I think for the sake of V1 and consistency with current forms, let's scope it so that only multi-page forms get the Review page. And then we can simplify from there for V2 if we see it as a burden for users. |
Testing out the PR environment: |
Pushed a change that should fixe this |
The fix works!!! Overall functionality looks good :) But I noticed an Edge case while I was testing (but it could be less priority): when I deleted a second page and immediately go to Preview, I'm still able to click the "Continue" button and it gets wonky. (If I clicked on another page and then hit Preview, I don't run into this bug). But it's more likely related to #4135, so could potentially be outside the scope of this card? |
Thinking this is related to auto-flow vs Review page |
Description
Currently the review page applies to all forms even short one-page or one-question forms.
Steps to reproduce
Expected behaviour
No need for review page when forms are very short and simple and when all answers can be checked on one page.
Make "Review" apply only to forms with multiple sections/pages.
Links
Related #3960 #4049
The text was updated successfully, but these errors were encountered: