Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Review page" from single-page forms as it is redundant #4075

Closed
1 task
anikbrazeau opened this issue Jul 26, 2024 · 8 comments · Fixed by #4091
Closed
1 task

Remove "Review page" from single-page forms as it is redundant #4075

anikbrazeau opened this issue Jul 26, 2024 · 8 comments · Fixed by #4091
Assignees
Labels
App bug Something isn't working

Comments

@anikbrazeau
Copy link
Member

anikbrazeau commented Jul 26, 2024

Description

Currently the review page applies to all forms even short one-page or one-question forms.

Steps to reproduce

  1. Go to GC Forms
  2. Create a single page form with two questions
  3. Create a multi-page form with many pages and questions
  4. Test out both forms
  5. See how review to check answers is redundant when there's only one page

Expected behaviour

No need for review page when forms are very short and simple and when all answers can be checked on one page.
Make "Review" apply only to forms with multiple sections/pages.

  • The current behavior is to only show the Review page if Conditional Logic is enabled. This task would add on to that, to only show the Review page if a form has groups (multiple pages).

Links

Related #3960 #4049

@anikbrazeau anikbrazeau added App bug Something isn't working labels Jul 26, 2024
@thiessenp-cds
Copy link
Contributor

thiessenp-cds commented Jul 26, 2024

I thought about this for a bit and I think it makes sense. A user on a single page form can skim their filled in answers on that page.
Though for the "forms are very short and simple" I'm not sure how to measure this? But I think the task is just for multi-page forms?

The current behavior is to only show the Review page if Conditional Logic is enabled. This task would add on to that, to only show the Review page if a form has groups (multiple pages). Does that sound right?

@anikbrazeau
Copy link
Member Author

Do we know what the behaviour would be for single-page existing forms that have already been published once conditional logic is released?

@thiessenp-cds thiessenp-cds self-assigned this Jul 26, 2024
@anikbrazeau
Copy link
Member Author

What if there was an option to "Skip Review page" ?
That might satisfy all needs?

@Abi-Nada
Copy link

Abi-Nada commented Jul 26, 2024

Do we know what the behaviour would be for single-page existing forms that have already been published once conditional logic is released?

I've validated that the Review Page will not show up for existing Published Forms that we have in GC Forms, once we flick the feature flag On.

What if there was an option to "Skip Review page" ?

I think for the sake of V1 and consistency with current forms, let's scope it so that only multi-page forms get the Review page. And then we can simplify from there for V2 if we see it as a burden for users.

@Abi-Nada
Copy link

Testing out the PR environment:
Review page doesn't show for single pages ✅
But also can't seem to toggle to the next page for multiple pages? ❌

Private Zenhub Video

@thiessenp-cds
Copy link
Contributor

Pushed a change that should fixe this

@Abi-Nada
Copy link

Abi-Nada commented Jul 31, 2024

The fix works!!! Overall functionality looks good :)

But I noticed an Edge case while I was testing (but it could be less priority): when I deleted a second page and immediately go to Preview, I'm still able to click the "Continue" button and it gets wonky. (If I clicked on another page and then hit Preview, I don't run into this bug).

But it's more likely related to #4135, so could potentially be outside the scope of this card?

Private Zenhub Video

@timarney
Copy link
Member

Thinking this is related to auto-flow vs Review page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants