Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressComplete - Canadian addresses contain labels for states and zip codes #4507

Closed
connorscarolyns opened this issue Oct 29, 2024 · 5 comments · Fixed by #4521
Closed
Assignees
Labels
App content development Development task / work required

Comments

@connorscarolyns
Copy link

Users have no control over the text in the address fields.

As I user, if I select Canadian only, I would expect the fields to change to Canadian only format.

Given that the majority of addresses collected will likely be Canadian, I suggest we limit our field labels to Canadian format until we can offer more international formats, or provide control to users to change the label text.

That is not to say we limit address searches to Canada only. Just the text for now.

@ShadeWyrm
Copy link
Contributor

Suggested change:
-> If International is selected keep labels as is.
-> If Canada only, use Canadian only elements. (eg: "Postal Code" instead of "Postal Code or Zip")

Would that work?

@connorscarolyns
Copy link
Author

For sure that would work, but I don't want to add scope when a simple label change would suffice for now.

@ShadeWyrm
Copy link
Contributor

Is about the same level of effort. :)

@connorscarolyns
Copy link
Author

Then I think it's a question for you and @anikbrazeau to decide on the right approach. :)

@anikbrazeau
Copy link
Member

anikbrazeau commented Oct 29, 2024

Sounds good!

If it's not a ton more effort we could do a more tailored set of labels for "Canadian addresses" and keep the generic broad labels for "International addresses"

IF Country = Canada, THEN: Specific

  • Street address // Adresse municipale
  • City, town, or community // Ville ou communauté
  • Province or territory // Province ou territoire
  • Postal code // Code postal

IF Country = Other, THEN: Generic

  • Street address // Adresse municipale
  • City, town, or community // Ville ou communauté
  • Province, territory, or state // Province, territoire ou état
  • Postal or zip code // Code postal ou zip

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App content development Development task / work required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants