Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the TokuDB engine assumes MariaDB #96

Open
crashtest83 opened this issue Jul 23, 2018 · 0 comments
Open

Using the TokuDB engine assumes MariaDB #96

crashtest83 opened this issue Jul 23, 2018 · 0 comments

Comments

@crashtest83
Copy link

Currently if you use TokuDB as the engine in your configuration, it uses the MariaDB syntax for setting the TokuDB table compression. If someone wanted to use Percona Server there would need to be a way to designate in the ListManager that it should use ROW_FORMAT instead of COMPRESSION for the tokudb_compression parameter.

I'm not certain of a clean way to designate that I am using MariaDB vs Percona in this instance, however. Perhaps a flag in the config?

static void append_engine(GString *request)
{
#ifdef _MYSQL
    g_string_append_printf(request, " ENGINE=%s", lmgr_config.db_config.engine);
 
    if (strcasecmp(lmgr_config.db_config.engine, "TokuDB") == 0)
        g_string_append_printf(request, " COMPRESSION=%s",
                               lmgr_config.db_config.tokudb_compression);
#endif
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant